Use Internal.AspNetCore.Sdk as an MSBuild SDK #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2018 11:13
…using it as an MSBuild SDK This gives Internal.AspNetCore.Sdk more control over the projects and how they operation. MSBuild SDKs evaluate before restore, and can alter MSBuild settings which packages cannot.
dougbu
added a commit
to aspnet/Mvc
that referenced
this pull request
Oct 4, 2018
- should resolve issues with occasional strange MSBuild caching issues in this repo - modeled after dotnet/Scaffolding#905 - follows aspnet/BuildTools#729 recommendation to check in global.config file - see also dotnet/msbuild#2914
dougbu
added a commit
to aspnet/Mvc
that referenced
this pull request
Oct 4, 2018
- should resolve issues with occasional strange MSBuild caching issues in this repo - modeled after dotnet/Scaffolding#905 - follows aspnet/BuildTools#729 recommendation to check in global.config file - see also dotnet/msbuild#2914 - use newer KoreBuild - `.\build.cmd -update /t:noop`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert from using Internal.AspNetCore.Sdk as a package reference to using it as an MSBuild SDK. This gives Internal.AspNetCore.Sdk more control over the projects and how they operation. MSBuild SDKs evaluate before restore, and can alter MSBuild settings which packages cannot.
cref aspnet/BuildTools#729